Locking down pr is the wrong approach (for most). Just provide a subtab inside PR tab that shows PRs from new people.
One tab for pr from contributors and users who already have PRs accepted in the repo.
Another tab from first time/no pr approved yet users. Maintainers can treat it as spam box if they want.
Occasionally, users can flag them as useful and maintainers can then look at them.
Give a button to move from others to PR tab.
Don't consider count of PRs inside others in the main count.
> Locking down pr is the wrong approach (for most).
Depends on your goal no? If your goal is to not accept random contributions or PRs, then being able to disable PRs completely, seems like the perfect approach? Up until this change (which happened almost a year ago, FWIW), it was impossible to just have a read-only mirror on GitHub that didn't get hit with drive-by PRs that just waste time, for example: https://github.com/videolan/dav1d/pulls?q=is%3Apr+state%3Acl...
I'm glad we can finally completely disable it, as it seems to just confuse people when you're not actually accepting PRs.
If the Microsoft purchase of Github wasn't a good indicator of the start of the end, this is it, I know a lot of people like to have "control" over things, but I have found so many fixes for software I use in un-merged PRs. Github moving towards closer and a closer system is good opp for alternatives to take some of that space. Nice.
I love that two of the comments presume that this change is recent and both for different reasons. It's as if most people don't know the current state of affairs unless it hits them with a hammer on the face.
I personally didn't know this, but I also don't submit PRs on github since a while ago.
> Pull requests and merge requests will no longer count toward Hacktoberfest rewards. It’s easier than ever to submit low-effort spam PRs to projects, so we’re listening to maintainer feedback and no longer actively incentivizing PRs. That being said, we certainly still encourage you to work on open source and share your work with the world during Hacktoberfest. Our new format focuses on learning and building together while reducing the burden of low-effort contributions on maintainers.
Another tab from first time/no pr approved yet users. Maintainers can treat it as spam box if they want.
Occasionally, users can flag them as useful and maintainers can then look at them.
Give a button to move from others to PR tab.
Don't consider count of PRs inside others in the main count.
Depends on your goal no? If your goal is to not accept random contributions or PRs, then being able to disable PRs completely, seems like the perfect approach? Up until this change (which happened almost a year ago, FWIW), it was impossible to just have a read-only mirror on GitHub that didn't get hit with drive-by PRs that just waste time, for example: https://github.com/videolan/dav1d/pulls?q=is%3Apr+state%3Acl...
I'm glad we can finally completely disable it, as it seems to just confuse people when you're not actually accepting PRs.
I personally didn't know this, but I also don't submit PRs on github since a while ago.
From the FAQ on https://hacktoberfest.com/ :
> Do I still submit pull requests to earn swag?
> Pull requests and merge requests will no longer count toward Hacktoberfest rewards. It’s easier than ever to submit low-effort spam PRs to projects, so we’re listening to maintainer feedback and no longer actively incentivizing PRs. That being said, we certainly still encourage you to work on open source and share your work with the world during Hacktoberfest. Our new format focuses on learning and building together while reducing the burden of low-effort contributions on maintainers.